Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comments): Emit CommentsEntityEvent as typed event #39304

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(comments): Emit CommentsEntityEvent as typed event #39304

merged 1 commit into from
Jul 19, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 11, 2023 •
edited
Loading

Fix #1539

Checklist

@nickvergessen nickvergessen added enhancement 3. to review Waiting for reviews feature: dav feature: comments pending documentation This pull request needs an associated documentation update labels Jul 11, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jul 11, 2023
@nickvergessen nickvergessen self-assigned this Jul 11, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team July 11, 2023 09:10
@nickvergessen nickvergessen marked this pull request as draft July 11, 2023 09:57
@nickvergessen nickvergessen mentioned this pull request Jul 13, 2023
Closed
@nickvergessen nickvergessen force-pushed the bugfix/noid/typed-event-comments-entity branch from de58d50 to 5cc8c03 Compare July 18, 2023 12:45
@nickvergessen
fix(comments): Emit CommentsEntityEvent as typed event
c3bc575 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/typed-event-comments-entity branch from 5cc8c03 to c3bc575 Compare July 18, 2023 14:20
@nickvergessen nickvergessen marked this pull request as ready for review July 18, 2023 14:21
kesselb
kesselb approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nickvergessen nickvergessen merged commit 489b480 into master Jul 19, 2023
38 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/typed-event-comments-entity branch July 19, 2023 15:25
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen
Copy link
Member Author

Docs in nextcloud/documentation#10858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@kesselb kesselb kesselb approved these changes

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement feature: comments feature: dav
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Comments: Replace CommentEntityEvent with a registration-bases solution within CommentsManager.
4 participants
@nickvergessen @marcelklehr @kesselb @come-nc