Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ocp)!: Drop \OCP\Util::writeLog #38548

Closed
wants to merge 3 commits into from
Closed

chore(ocp)!: Drop \OCP\Util::writeLog #38548

wants to merge 3 commits into from

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 31, 2023 •
edited

Summary

The method was deprecated in Nextcloud 13, released 2018-02-06.

TODO

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 31, 2023
@ChristophWurst ChristophWurst self-assigned this May 31, 2023
@ChristophWurst ChristophWurst mentioned this pull request May 31, 2023
Closed
CarlSchwan
CarlSchwan approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice one less way to write logs :)

solracsf
solracsf approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve (this has been logged).

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish pending documentation This pull request needs an associated documentation update and removed 3. to review Waiting for reviews labels May 31, 2023
susnux
susnux approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ChristophWurst
Copy link
Member Author

Fixed unused imports. Should be fine now.

kesselb
kesselb reviewed May 31, 2023
View reviewed changes
lib/private/Tags.php
@@ -529,7 +530,7 @@ public function tagAs($objid, $tag) {
if (is_string($tag) && !is_numeric($tag)) {
$tag = trim($tag);
if ($tag === '') {
\OCP\Util::writeLog('core', __METHOD__.', Cannot add an empty tag', ILogger::DEBUG);
logger('core')->debug(__METHOD__.', Cannot add an empty tag');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->logger is also available ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@szaimen szaimen force-pushed the chore/ocp/drop-until-writelog branch from b915825 to d995f11 Compare June 12, 2023 07:43
@szaimen szaimen enabled auto-merge June 12, 2023 07:44
@ChristophWurst
chore: Replace \OCP\Util::writeLog with \OCP\Log\logger calls
504a8ea 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore(ocp)!: Drop \OCP\Util::writeLog
76f017a 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore(appframework): Remove deprecated and unused DIContainer::log
e2faf6d 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Feb 23, 2024
@skjnldsv
Copy link
Member

Superseded by #40565

@skjnldsv skjnldsv closed this Feb 23, 2024
@skjnldsv skjnldsv deleted the chore/ocp/drop-until-writelog branch February 23, 2024 14:12
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb left review comments

@rullzer rullzer rullzer approved these changes

@susnux susnux susnux approved these changes

@solracsf solracsf solracsf approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@JohannesGGE JohannesGGE Awaiting requested review from JohannesGGE

Assignees

@ChristophWurst ChristophWurst

Labels
2. developing Work in progress feature: logging technical debt
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ChristophWurst @skjnldsv @rullzer @susnux @kesselb @solracsf @CarlSchwan