Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods Util::writeLog and DIContainer::log #40565

Merged
merged 1 commit into from Sep 26, 2023
Merged

Remove deprecated methods Util::writeLog and DIContainer::log #40565

merged 1 commit into from Sep 26, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 21, 2023 •
edited

Summary

Remove deprecated methods Util::writeLog and DIContainer::log.
Helps reducing use of ILogger as well.

TODO

  • Check applications for usage of writeLog

Checklist

@come-nc come-nc added 3. to review Waiting for reviews technical debt labels Sep 21, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Sep 21, 2023
@come-nc come-nc self-assigned this Sep 21, 2023
@come-nc
Remove deprecated methods Util::writeLog and DIContainer::log
f68d4f7 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc requested review from nickvergessen, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team September 25, 2023 08:37
@come-nc come-nc merged commit 3a56ecc into master Sep 26, 2023
36 of 38 checks passed
@come-nc come-nc deleted the fix/remove-writelog branch September 26, 2023 10:09
@ChristophWurst
Copy link
Member

Documentation (manuals or wiki) has been updated or is not required

Why is it not required?

@nickvergessen
Copy link
Member

Should be mentioned, yes

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Sep 26, 2023
@come-nc come-nc mentioned this pull request Sep 28, 2023
Merged
@come-nc come-nc removed the pending documentation This pull request needs an associated documentation update label Nov 13, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@come-nc @ChristophWurst @nickvergessen @Altahrim