also log stream size when reporting unexpected chunk size #38765
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
Fenn-CS
and removed request for
a team
Merged
icewind1991
force-pushed
the
stream-assembly-stream-size
branch
from
ee023bc
to
5ce6f65
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
force-pushed
the
stream-assembly-stream-size
branch
from
5ce6f65
to
f6d5716
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream size should give a more accurate view of how large the node is on the storage, which might be different from how big that filecache thinks the node is in error cases.
This should help distinguishing issues with writing the chunk from issues with reading the node.