Uses PHP8's constructor property promotion core/Command/App,/Background, and /Broadcast #38769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
nickvergessen,
come-nc,
a team,
icewind1991 and
Fenn-CS
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ILogger $logger) { | ||
| public function __construct( | ||
| protected IJobList $jobList, | ||
| protected ILogger $logger, |
Check notice
Code scanning / Psalm
DeprecatedInterface Note
come-nc
reviewed
Jun 13, 2023
come-nc
approved these changes
Jun 13, 2023
artonge
approved these changes
Jun 19, 2023
added 2 commits
June 19, 2023 12:55
in core/Command/App, /Background, and /Broadcast classes. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Based on: nextcloud#38764 (comment) Signed-off-by: Faraz Samapoor <fsa@adlas.at>
artonge
force-pushed
the
constructor_property_promotion_in_core_command_part6
branch
from
9d86d24
to
cda0f74
Compare
fsamapoor
deleted the
constructor_property_promotion_in_core_command_part6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #38636, #38637, and #38638 PRs, I have made the required adjustments to the
/core/Command/namespace as well.I figured I should split the changes into multiple PRs to make reviewing the changes easier.
This PR refactors
/core/Command/App,/core/Command/Background, and/core/Command/Broadcastclasses by using PHP8's constructor property promotion to remove redundant lines and make the code cleaner.