[1/3] Refactors /core controllers using constructor property promotion. #38636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
come-nc
and removed request for
a team
come-nc
reviewed
Jun 5, 2023
come-nc
reviewed
Jun 5, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
come-nc
reviewed
Jun 5, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
added a commit
to fsamapoor/server
that referenced
this pull request
Jun 5, 2023
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
added a commit
to fsamapoor/server
that referenced
this pull request
Jun 5, 2023
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
come-nc
approved these changes
Jun 5, 2023
This was referenced Jun 12, 2023
This was referenced Jun 12, 2023
Merged
Merged
artonge
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 16, 2023
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
artonge
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 19, 2023
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
artonge
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 20, 2023
Based on nextcloud#38636 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of the three-part refactoring of the
/corecontrollers by using PHP8's constructor property promotion to remove redundant lines and make the code cleaner.I figured I should split the changes into three parts to make reviewing the changes easier.