fix(core): Do not invert app menu text color

[Hephi2]

• Resolves: [Bug]: Inverted app label color for light background color #38759
  Fixes [Bug]: Inverted app label color for light background color #38759

Summary

Instead of inverting the color of the whole app entry in the menubar when using a light background, only the color of the app icon is inverted. The invertion of the label color already happens here:

server/apps/theming/lib/Themes/CommonThemeTrait.php

Line 68 in 63bf207

'--color-primary-element-text' => $this->util->invertTextColor($colorPrimaryElement) ? '#000000' : '#ffffff',

##Screenshots
Before:

After:

Tested on Chrome, Edge, Firefox and Opera Browser

[szaimen]

Seems to fix the linked problem in my testing

[szaimen]

/compile /

[mejo-]

The cypress tests need to be fixed first, I think @Hephi2 will do so later.

[Hephi2]

/compile

[Hephi2]

/compile

[susnux]

/compile

It is most of the time faster to compile and commit it locally :)

[mejo-]

It is most of the time faster to compile and commit it locally :)

Thanks @susnux! But for the sake of easier backports its still better to keep source changes and compiled asset changes in separate commits, no?

[mejo-]

I don't understand why the Cypress Tests fail here 🤔

[juliushaertl]

Restarted.

[susnux]

Locally it works. Cypress seems currently broken on CI (server master) (see all other CI runs)

[mejo-]

I splitted the PR between source code changes and compiled JS assets and rebased. Cypress CI test issues seem to have solved themselves 🪄

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[Hephi2]

/backport 7f86198 to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport