Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecation warnings to debug #38852

Merged
merged 4 commits into from Jun 24, 2023
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 16, 2023

Same as #37816 but for js

@szaimen szaimen added the 3. to review Waiting for reviews label Jun 16, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 16, 2023
@szaimen szaimen requested review from ChristophWurst, skjnldsv, a team, artonge and Pytal and removed request for a team June 16, 2023 11:23
szaimen

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

Debug logs and debug mode only

@szaimen szaimen force-pushed the enh/noid/move-deprecation-warnings branch from ff5cf95 to d814369 Compare June 16, 2023 12:05
@szaimen
Copy link
Contributor Author

szaimen commented Jun 16, 2023

@ChristophWurst addressed

@szaimen
Copy link
Contributor Author

szaimen commented Jun 16, 2023

/compile /

@ShGKme
Copy link
Contributor

ShGKme commented Jun 16, 2023

In browsers debug log is hidden by default. If some app developers are using deprecated stuff, they will know about it only if they directly turn on the verbose log level. Is it intended?

And there will be no difference between important deprecation warning messages from the libs and verbose debug logs for app/lib in terms of log levels.

@szaimen
Copy link
Contributor Author

szaimen commented Jun 16, 2023

And there will be no difference between important deprecation warning messages from the libs and verbose debug logs for app/lib in terms of log levels.

that is what I was wondering about as well. So my suggestion would be to show these as warnings if debug mode is enabled. WDYT?

@ShGKme
Copy link
Contributor

ShGKme commented Jun 19, 2023

that is what I was wondering about as well. So my suggestion would be to show these as warnings if debug mode is enabled. WDYT?

I'd either keep console.warn for deprecation warnings or make something more high-level.

@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

I'd either keep console.warn for deprecation warnings or make something more high-level.

please check out 6dd433a

@szaimen szaimen requested a review from ShGKme June 24, 2023 13:11
@szaimen szaimen requested review from skjnldsv and removed request for skjnldsv June 24, 2023 14:19
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
@skjnldsv skjnldsv force-pushed the enh/noid/move-deprecation-warnings branch from 6dd433a to 43bc880 Compare June 24, 2023 14:54
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 24, 2023
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/noid/move-deprecation-warnings branch from 43bc880 to 95deec1 Compare June 24, 2023 15:00
@szaimen szaimen enabled auto-merge June 24, 2023 15:01
@skjnldsv skjnldsv disabled auto-merge June 24, 2023 15:16
@skjnldsv skjnldsv merged commit 10d563a into master Jun 24, 2023
37 of 38 checks passed
@skjnldsv skjnldsv deleted the enh/noid/move-deprecation-warnings branch June 24, 2023 15:16
@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

#38980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants