Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Move deprecation warnings to debug #38980

Merged
merged 1 commit into from Jun 24, 2023
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 24, 2023

Manual backport of #38852 to stable27

@szaimen szaimen added the 3. to review Waiting for reviews label Jun 24, 2023
@szaimen szaimen added this to the Nextcloud 27.0.1 milestone Jun 24, 2023
@szaimen szaimen changed the title Move deprecation warnings to debug [stable27] Move deprecation warnings to debug Jun 24, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

/compile amend /

@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

@skjnldsv
Copy link
Member

skjnldsv commented Jun 24, 2023

skjnldsv looks like the compile command fails? nextcloud/server/actions/runs/5365075296/jobs/9733658146

Looks like the path is different, I think we need to fix the workflow
https://github.com/nextcloud/.github/blob/4eca92e0661636a7815ad98e4c38c2408f71bef2/workflow-templates/command-compile.yml#L37-L45
EDIT: wrong reference, this is not where the path comes from

@skjnldsv

This comment was marked as resolved.

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Jun 24, 2023

Why does it work now?

@skjnldsv
Copy link
Member

giphy

@szaimen szaimen requested review from a team and Fenn-CS and removed request for a team June 24, 2023 16:29
@szaimen szaimen merged commit 8880e38 into stable27 Jun 24, 2023
34 of 38 checks passed
@szaimen szaimen deleted the backort/38852/stable27 branch June 24, 2023 16:49
@szaimen
Copy link
Contributor Author

szaimen commented Jul 10, 2023

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz blizzz mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants