Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix confusion around mail settings and improve layout a bit #38868

Merged
merged 1 commit into from Jun 19, 2023
Merged

fix confusion around mail settings and improve layout a bit #38868

merged 1 commit into from Jun 19, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 17, 2023 •
edited

@szaimen szaimen added the 2. developing Work in progress label Jun 17, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 17, 2023
@szaimen szaimen force-pushed the enh/noid/fix-mail-confusion branch from 61c0322 to eb1afa8 Compare June 17, 2023 16:18
@szaimen
fix confusion around mail settings
7918bb1 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/fix-mail-confusion branch from eb1afa8 to 7918bb1 Compare June 17, 2023 16:26
@szaimen szaimen changed the title fix confusion around mail settings fix confusion around mail settings and improve layout a bit Jun 17, 2023
@szaimen szaimen mentioned this pull request Jun 17, 2023
Merged
1 task
@szaimen szaimen marked this pull request as ready for review June 17, 2023 16:46
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 17, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Jun 17, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Jun 17, 2023

/backport to stable26

come-nc
come-nc approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the wording, not sure I understand all the code changes. Did not test.

@szaimen szaimen merged commit b33cbec into master Jun 19, 2023
39 checks passed
@szaimen szaimen deleted the enh/noid/fix-mail-confusion branch June 19, 2023 09:35
This was referenced Jun 19, 2023
Merged
Merged
@szaimen szaimen mentioned this pull request Jun 19, 2023
Closed
8 tasks
@joshtrichards joshtrichards mentioned this pull request Jul 15, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szaimen @marcoambrosini @come-nc