Refactor lib/private/Calendar #38990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly using PHP8's constructor property promotion. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
szaimen
requested review from
ChristophWurst,
miaulalala,
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
ChristophWurst
changed the title
ChristophWurst
approved these changes
Jun 26, 2023
Fenn-CS
approved these changes
Jun 26, 2023
miaulalala
approved these changes
Jun 27, 2023
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous PRs taking advantage of PHP8's constructor property promotion in
/core/namespace, I have also made the required adjustments to the classes in/lib/private/Calendarnamespace.The improvements in this PRs include: