Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): Assign initial value to typed CalendarQuery properties #39504

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix(caldav): Assign initial value to typed CalendarQuery properties #39504

merged 2 commits into from
Jul 20, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 20, 2023 •
edited
Loading

Summary

The props are not initialized otherwise and cause a PHP error: "Typed property OC\\Calendar\\CalendarQuery::$limit must not be accessed before initialization

TODO

  • Fix

Checklist

@ChristophWurst
fix(caldav): Assign initial value to typed CalendarQuery properties
2d3d396 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews feature: dav regression feature: caldav Related to CalDAV internals labels Jul 20, 2023
@ChristophWurst ChristophWurst self-assigned this Jul 20, 2023
fsamapoor
fsamapoor approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@fsamapoor fsamapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thank you for fixing it.

@miaulalala miaulalala mentioned this pull request Jul 20, 2023
Closed
5 tasks
@miaulalala miaulalala merged commit af6bb98 into master Jul 20, 2023
@miaulalala miaulalala deleted the fix/caldav/access-typed-searchquery-property-without-init branch July 20, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@fsamapoor fsamapoor fsamapoor approved these changes

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: dav regression
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @fsamapoor @miaulalala