Refactor admin audit app #39192
Refactor admin audit app #39192
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danialRahimy
force-pushed
the
refactor-admin-audit-app
branch
from
50f672c
to
cd9b081
Compare
|
Hey @szaimen I opened this PR last week, but haven't been assigned to any reviewers yet. Is there anything that I could do? Thanks. |
szaimen
requested review from
blizzz,
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
|
Thanks for the ping! I requested some reviewers. |
|
Dear @szaimen Would it be necessary for me to take any action in order to proceed with the pull request? |
danialRahimy
force-pushed
the
refactor-admin-audit-app
branch
from
cd9b081
to
67f0d31
Compare
|
@nextcloud/server-backend please review! |
| IShare::TYPE_REMOTE_GROUP => $this->sharedRemoteGroupType($params), | ||
| IShare::TYPE_DECK => $this->sharedDeckType($params), | ||
| IShare::TYPE_SCIENCEMESH => $this->sharedSciencemeshType($params), | ||
| default => null, |
There was a problem hiding this comment.
I wonder if this one should fail (or at least log) if an unknown type is used.
There was a problem hiding this comment.
Before my modifications, if a type didn't match the conditions, no action was taken.
I'm uncertain whether to implement logging or throw a specialized exception to handle unknown types.
There was a problem hiding this comment.
Same here, maybe it will ring a bell for someone :)
There was a problem hiding this comment.
In my opinion, removing redundant annotations make the code that much cleaner. When a method's parameter is typed, having the exact type hint as an annotation does not add any value to the mix. I think it would be great if you could also review the annotations in this PR.
I would also recommend writing a summary of the changes you have made in your PR's description and explaining briefly how those changes would improve the codebase.
| ] | ||
| ); | ||
| } | ||
| match ($params['shareType']) { |
There was a problem hiding this comment.
The use of match when the return value is not used is really confusing.
| @@ -60,6 +60,7 @@ | |||
| use OCP\EventDispatcher\IEventDispatcher; | |||
| use OCP\IConfig; | |||
| use OCP\IGroupManager; | |||
| use OCP\IServerContainer; | |||
There was a problem hiding this comment.
Why? It does not seem used.
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
Co-authored-by: Benjamin Gaussorgues <github-fa3ie@altahrim.net> Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
…and modern syntax. Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
danialRahimy
force-pushed
the
refactor-admin-audit-app
branch
from
f250821
to
5db849f
Compare
Summary
Refactor admin audit app
TODO
Checklist