Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/private #39245

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor lib/private #39245

wants to merge 3 commits into from

Conversation

shdehnavi
Copy link
Contributor

@shdehnavi shdehnavi commented Jul 8, 2023 •
edited
Loading

Summary

The required adjustments have been made to the following classes under /lib/private namespace:

  • Updater.php
  • TempManager.php
  • Tags.php
  • TagManager.php
  • TemplateLayout.php
  • URLGenerator.php

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding types to properties
  • Updating doc blocks
  • Replacing substr with PHP8's str_ends_with and str_starts_with

Checklist

@shdehnavi
Refactor lib/private
fcb2c1b 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2023
View reviewed changes
lib/private/TagManager.php Fixed Show fixed Hide fixed
lib/private/TagManager.php Fixed Show fixed Hide fixed
lib/private/TempManager.php Fixed Show fixed Hide fixed
lib/private/TempManager.php Fixed Show fixed Hide fixed
@shdehnavi
Make adjustments based on the Psalm code scanning
0251187 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2023
View reviewed changes
lib/private/TagManager.php Fixed Show fixed Hide fixed
@shdehnavi
Make adjustments based on the Psalm code scanning
aafc51a 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@icewind1991 icewind1991 Awaiting requested review from icewind1991

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shdehnavi @blizzz @solracsf @skjnldsv