Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set double outline to buttons in focus state #39277

Merged
merged 1 commit into from Jul 11, 2023
Merged

Set double outline to buttons in focus state #39277

merged 1 commit into from Jul 11, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jul 10, 2023 •
edited

Summary

Set double outline to buttons in focus state

🏚️ Before
image

🏡 After

Screenshot from 2023-07-10 16-00-16
Screenshot from 2023-07-10 15-59-28
Screenshot from 2023-07-10 15-41-07
Screenshot from 2023-07-10 15-36-30
Screenshot from 2023-07-10 10-32-22
Screenshot from 2023-07-10 10-31-43
Screenshot from 2023-07-04 09-04-14
Screenshot from 2023-07-03 17-42-59
Screenshot from 2023-07-03 17-27-30
Screenshot from 2023-07-03 17-19-16
Screenshot from 2023-07-10 16-15-58
Screenshot from 2023-07-10 16-15-31

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jul 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jul 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title Test/4193 buttons accessibility improvements Set double outline to buttons in focus state Jul 10, 2023
marcoambrosini

This comment was marked as resolved.

Sign in to view

@JuliaKirschenheuter
Copy link
Contributor Author

but why is this done here instead of within the button component in the vue library itself?

nextcloud-libraries/nextcloud-vue#4319
it was unfortunately not enough

@JuliaKirschenheuter
Set double outline to buttons in focus state
34bbb4e 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the test/4193-Buttons_accessibility_improvements branch from 7f5f98d to 34bbb4e Compare July 11, 2023 09:29
@JuliaKirschenheuter JuliaKirschenheuter merged commit a756600 into master Jul 11, 2023
40 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the test/4193-Buttons_accessibility_improvements branch July 11, 2023 14:52
@Pytal Pytal mentioned this pull request Apr 28, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV] Buttons accessibility improvements [BITV] 9.1.4.1/3.1 - Styling menubar - active contrast
5 participants
@JuliaKirschenheuter @artonge @Pytal @marcoambrosini @nimishavijay