feat(contactsinteraction): allow users to disable contacts interaction addressbook #39372
Conversation
tcitworld
added
3. to review
tcitworld
requested review from
Pytal,
JuliaKirschenheuter,
kesselb,
miaulalala,
ChristophWurst,
GretaD,
hamza221 and
st3iny
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * | ||
| * @param Server $server | ||
| */ | ||
| public function initialize(Server $server) { |
Check notice
Code scanning / Psalm
MissingReturnType Note
|
@tcitworld But what if I like this addressbook, and I only need to delete one contact from this addressbook. Let's say I have sent an email to a non-existent address, I get a bounce-back NDR email, and the non-existent contact goes into the "Recently contacted" addressbook, but because the email address is invalid, I want to delete it, while still enjoying the "Recently contacted" addressbook. This PR seems to solve only 50% of the current issue we have with this addressbook. I think deleting/disabling the whole addressbook does not address the described issue I have. |
|
@HLFH We will keep the issue opened for this specific aspect |
tcitworld
force-pushed
the
contctsinteraction-usersetting
branch
from
c43c995
to
b6710f4
Compare
|
Rebased |
There was a problem hiding this comment.
Deleting the address book from the Contacts app didn't work. The DELETE request itself worked and the address book vanishes until the next page reload. It will still contain all of its former contacts after the page reload.
Disabling it via the personal settings works. However, the address book is still shown in the Contacts settings modal (with 0 contacts and 0 groups) afterwards.
tcitworld
added
2. developing
tcitworld
force-pushed
the
contctsinteraction-usersetting
branch
from
b6710f4
to
529d2d9
Compare
tcitworld
added
3. to review
Fixed this. |
| */ | ||
| class Plugin extends ServerPlugin { | ||
|
|
||
| protected Server $server; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
apps/contactsinteraction/lib/Listeners/UserPreferenceListener.php
Outdated
Show resolved
Hide resolved
…n addressbook This allows simple users to opt-out of the contacts interaction addressbook even if admins have the app installed. Similar to how the birthday calendar works, the functionnality can be toggled in the user's settings or by doing a DELETE on the addressbook. A new contacts personal section has been added to contain this new setting. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
contctsinteraction-usersetting
branch
from
529d2d9
to
fd59640
Compare
| return; | ||
| } | ||
|
|
||
| $enabled = $event->getConfigValue() === 'yes'; |
Check notice
Code scanning / Psalm
PossiblyUndefinedMethod Note
This allows simple users to opt-out of the contacts interaction addressbook even if admins have the app installed.
Similar to how the birthday calendar works, the functionnality can be toggled in the user's settings or by doing a DELETE on the addressbook.
A new contacts personal section has been added to contain this new setting.
TODO
Checklist