fix: Also cleanup version metadata if expiring

[juliushaertl]

Found while writing e2e tests for #39140

Steps to reproduce:

• Upload some file multiple times with close timestamps
• Run cron which expires versions (ref

  server/apps/files_versions/lib/Storage.php

  Lines 87 to 100 in 26c7cda

  	private static $max_versions_per_interval = [
  	//first 10sec, one version every 2sec
  	1 => ['intervalEndsAfter' => 10, 'step' => 2],
  	//next minute, one version every 10sec
  	2 => ['intervalEndsAfter' => 60, 'step' => 10],
  	//next hour, one version every minute
  	3 => ['intervalEndsAfter' => 3600, 'step' => 60],
  	//next 24h, one version every hour
  	4 => ['intervalEndsAfter' => 86400, 'step' => 3600],
  	//next 30days, one version per day
  	5 => ['intervalEndsAfter' => 2592000, 'step' => 86400],
  	//until the end one version per week
  	6 => ['intervalEndsAfter' => -1, 'step' => 604800],
  	];

  )

This leads to the version files being deleted while the oc_files_versions table still contains references, meaning that they show up as broken files in the versions sidebar.

Ideally expiration should also be handled by the version manager, but this requires some larger efforts and is not backportable.

Quick script to reproduce:

#!/bin/bash
NC_URL=https://admin:admin@nextcloud.local/remote.php/webdav/

filename=$(date | md5sum | cut -d " " -f 1)
echo $filename

echo a1 > 1/$filename.md
sleep 2
echo a2 > 2/$filename.md
sleep 2
echo a3 > 3/$filename.md
sleep 2
echo a4 > 4/$filename.md
sleep 2
echo a5 > 5/$filename.md

curl -T "1/$filename.md" "$NC_URL/$filename.md"
curl -T "2/$filename.md" "$NC_URL/$filename.md"
curl -T "3/$filename.md" "$NC_URL/$filename.md"
curl -T "4/$filename.md" "$NC_URL/$filename.md"
curl -T "5/$filename.md" "$NC_URL/$filename.md"

Afterwards you can compare the following sql queries before and after cron for validation:

# with the echoed filename
select * from oc_filecache where name like '3882259fffd1ef36e300511488e561be%';
# with the file id
select * from oc_files_versions where file_id = 8740;

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[juliushaertl]

/backport to stable27

[juliushaertl]

/backport to stable26

[solracsf]

@juliushaertl no 25 ?

[juliushaertl]

Only 26+ is affected where the new table for metadata was introduced