Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests for smart picker, code block, mermaid and version view/compare #4663

Merged
merged 6 commits into from Aug 30, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 9, 2023

  • tests(cypress): Add smartpicker tests
  • tests(cypress): Add code block and mermaid tests
  • tests(cypress): Add version view and compare tests

🚧 TODO

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Aug 9, 2023

2 flaky tests on run #11926 ↗︎

0 143 18 0 Flakiness 2

Details:

Cypress tests for smart picker, code block, mermaid and version view/compare
Project: Text Commit: 869f8e25ad
Status: Passed Duration: 06:54 💡
Started: Aug 30, 2023 9:09 AM Ended: Aug 30, 2023 9:16 AM
Flakiness  shortcuts.spec.js • 1 flaky test

View Output Video

Test Artifacts
keyboard shortcuts > unordered-list Output Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl force-pushed the tests/cypress-hub6 branch 2 times, most recently from 48a4bcf to 7b4be33 Compare August 10, 2023 12:17
@juliushaertl juliushaertl marked this pull request as ready for review August 10, 2023 12:20
@juliushaertl juliushaertl added tests If you write them we ♥ you 3. to review labels Aug 10, 2023
@juliushaertl juliushaertl changed the title tests/cypress hub6 Cypress tests for smart picker, code block, mermaid and version view/compare Aug 10, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Aug 10, 2023
@juliushaertl juliushaertl force-pushed the tests/cypress-hub6 branch 2 times, most recently from e7c0508 to e00b4b1 Compare August 14, 2023 07:46
@juliushaertl juliushaertl mentioned this pull request Aug 24, 2023
4 tasks
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two .only need to be removed still. Approving anyway so you can move on afterwards.

Comment on lines +29 to +30
expect('To-Do list').to.be.oneOf(entries)
expect('Table').to.be.oneOf(entries)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still expected after the recent reordering that put default actions on top again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for the test as there is only very limited default pickers. Will check though.

cypress/e2e/SmartPicker.spec.js Outdated Show resolved Hide resolved
cypress/e2e/nodes/CodeBlock.spec.js Outdated Show resolved Hide resolved
cypress/support/e2e.js Show resolved Hide resolved
@juliushaertl
Copy link
Member Author

Okay, needs some more fixing I guess

@juliushaertl juliushaertl force-pushed the tests/cypress-hub6 branch 2 times, most recently from cf8588a to 59d9f0c Compare August 29, 2023 19:01
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

Ok, new failure due to the nextcloud-vue update that changed the label position

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 7394da2 into main Aug 30, 2023
31 checks passed
@juliushaertl juliushaertl deleted the tests/cypress-hub6 branch August 30, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants