New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress tests for smart picker, code block, mermaid and version view/compare #4663
Conversation
2 flaky tests on run #11926 ↗︎
Details:
shortcuts.spec.js • 1 flaky test
api/SyncServiceProvider.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
48a4bcf
to
7b4be33
Compare
e7c0508
to
e00b4b1
Compare
e00b4b1
to
5774600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Two .only
need to be removed still. Approving anyway so you can move on afterwards.
expect('To-Do list').to.be.oneOf(entries) | ||
expect('Table').to.be.oneOf(entries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still expected after the recent reordering that put default actions on top again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine for the test as there is only very limited default pickers. Will check though.
5774600
to
f1ae8e3
Compare
Okay, needs some more fixing I guess |
cf8588a
to
59d9f0c
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
59d9f0c
to
6814cda
Compare
Ok, new failure due to the nextcloud-vue update that changed the label position |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)