Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass proper viewer filename #39789

Merged
merged 2 commits into from Aug 10, 2023
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 10, 2023

Fix loading versions in subdirectories as the path is not having a trailing directory separator.

Found when writing tests for this in nextcloud/text#4663

Checklist

@juliushaertl juliushaertl requested review from skjnldsv, a team, susnux and Pytal and removed request for a team August 10, 2023 09:11
@juliushaertl juliushaertl added bug 3. to review Waiting for reviews labels Aug 10, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Aug 10, 2023
@juliushaertl
Copy link
Member Author

/backport to stable27

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/version-subdirectory branch from c97ce8b to 2c8753a Compare August 10, 2023 10:43
@juliushaertl
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit 8436694 into master Aug 10, 2023
37 of 38 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/version-subdirectory branch August 10, 2023 11:44
@juliushaertl
Copy link
Member Author

/backport 2c8753a to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants