Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't preload metadata for the sub-childen #39860

Merged
merged 2 commits into from Aug 16, 2023

Conversation

icewind1991
Copy link
Member

Fixes to broad preloading logic introduced with #39694

  • Only preload when Depth = 1, this stops preloading for the children of sub-folders
  • Don't trigger preload logic when no metadata is requested.

Signed-off-by: Robin Appelman <robin@icewind.nl>
…ested

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 14, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Aug 14, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and Fenn-CS and removed request for a team August 14, 2023 11:01
@icewind1991 icewind1991 marked this pull request as ready for review August 14, 2023 12:10
@icewind1991 icewind1991 merged commit 6f6e244 into master Aug 16, 2023
42 checks passed
@icewind1991 icewind1991 deleted the metadata-dont-preload-subfolders branch August 16, 2023 15:14
@icewind1991
Copy link
Member Author

/backport to stable27

@pulsejet
Copy link
Member

This patch cut down my SQL requests to half 👀
Should've been labelled Performance 🚀😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants