syntactic migration on files_external/AjaxController #39957
+30
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return true; | ||
| } else { | ||
| public function saveGlobalCredentials(string $uid, string $user, string $password): bool { | ||
| if ($this->userSession->getUser()->getUID() !== $uid) { |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
40584f1
to
97a797b
Compare
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
4 times, most recently
from
1275bdf
to
435f475
Compare
skjnldsv
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
435f475
to
e55087b
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension of #39895