Refactor OC\Server::getURLGenerator
#40128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
summersab
force-pushed
the
refactor/OC-Server-getURLGenerator
branch
from
67553c0
to
8057c4c
Compare
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersab
force-pushed
the
refactor/OC-Server-getURLGenerator
branch
from
8057c4c
to
23f1bee
Compare
Merged
|
conflicts |
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getURLGeneratorand replaces it withOC\Server::get(\OCP\IURLGenerator::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\IURLGeneratorclass is imported via theusedirective.