Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @nextcloud/vue to v8 beta 6 #40451

Closed
wants to merge 2 commits into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 15, 2023

Summary

Release notes https://github.com/nextcloud-libraries/nextcloud-vue/releases/tag/v8.0.0-beta.6

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added the 3. to review Waiting for reviews label Sep 15, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Sep 15, 2023
@Pytal Pytal self-assigned this Sep 15, 2023
@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2023
@Pytal
Copy link
Member Author

Pytal commented Sep 16, 2023

All component styling is broken

This is because styles are no longer embedded in the js dist since nextcloud-libraries/nextcloud-vue#4386, with the css being separated into the assets folder https://unpkg.com/browse/@nextcloud/vue@8.0.0-beta.6/dist/assets/

Webpack should handle these css imports, i.e. https://unpkg.com/browse/@nextcloud/vue@8.0.0-beta.6/dist/Components/NcButton.mjs, with css-loader but is not working here and I'm not sure why 🤔

Any ideas @ShGKme @susnux ?

@susnux
Copy link
Contributor

susnux commented Sep 16, 2023

Any ideas @ShGKme @susnux ?

Webpack is working fine, the styles are included... But there is a bug:
When running development build for the vue library the assets are named correctly, but when running production build the CJS and MJS build will emit two sets of assets with different naming.
Meaning CJS overrides MJS assets (the css files), so that the wrong styles are loaded when using mjs.

I will work on a fix.

@susnux
Copy link
Contributor

susnux commented Sep 16, 2023

@Pytal resolved the issue, see nextcloud-libraries/nextcloud-vue#4531

(Tested on current server master and works :) )

@ShGKme
Copy link
Contributor

ShGKme commented Sep 20, 2023

@susnux Is the server compatible now with @nextcloud/vue@8.0.0-beta.6?

@susnux
Copy link
Contributor

susnux commented Sep 21, 2023

@susnux Is the server compatible now with @nextcloud/vue@8.0.0-beta.6?

No but we @nextcloud/vue master -> we need to release a beta.7 and then update server

@susnux
Copy link
Contributor

susnux commented Sep 21, 2023

(but I would really like to have NcDialog and the button content handling available in the next release 😓 )

@susnux susnux deleted the deps/nextcloud/vue-8.0.0-beta.6 branch September 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants