Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add x-requested-with header in requests to Nextcloud #40471

Merged
merged 2 commits into from Oct 16, 2023

Conversation

julien-nc
Copy link
Member

refs #39924

Adding this header systematically is breaking any usage of the MapLibre map library for example because the lib reaches endpoints with a strict CORS policy which does not accept extra headers.

@julien-nc julien-nc added bug 3. to review Waiting for reviews labels Sep 18, 2023
@julien-nc julien-nc added this to the Nextcloud 28 milestone Sep 18, 2023
@juliushaertl
Copy link
Member

Conflicts on dist bundles ;)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
Copy link
Member Author

Cypress failures are unrelated (theming and user settings).

@julien-nc julien-nc merged commit 9bf824e into master Oct 16, 2023
40 of 43 checks passed
@julien-nc julien-nc deleted the enh/fix-x-requested-with branch October 16, 2023 10:06
@juliushaertl
Copy link
Member

Small follow up fix is in #40944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants