fix: Properly handle fetch API calls with string as resource #40944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Oct 17, 2023
artonge
approved these changes
Oct 17, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
force-pushed
the
bugfix/noid/fetch-api
branch
from
29586a8
to
5a879eb
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
added
4. to release
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fix to #40471 which broke fetch calls that just used a string as the URL.
Can be for example seen in the file picker PROPFIND request
https://developer.mozilla.org/en-US/docs/Web/API/fetch#resource