[stable27] Revert change that made OC.Util.humanFileSize return decimal sizes instead of binary

[susnux]

• Resolves: wrong user quota in the user administration #38874

Summary

Previously the OC.Util.humanFileSize was returning file sizes base 2, meaning 1024 bytes = 1 KiB, but the @nextcloud/files library had a regression that set the default to base 10. Meaning 1000 bytes = 1 KB.

This is fixed for current @nextcloud/libraries (3.0.0-beta.23) but for stable27 we need to fix this manually by wrapping the function.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

PS: This is just a bugfix so I will not touch the issue that we using binary sizes but showing decimal units. This just restores the previous behavior.

[susnux]

drone unrelated

[come-nc]

I think this broke node tests: https://github.com/nextcloud/server/actions/runs/6301358504/job/17107304772

  OCA.Files.FileList tests
    Removing files from the list
      ✗ Removes file from list when calling remove() and updates summary
	Expected '69 KB' to equal '70 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filelistSpec.js:542:46)

    Deleting files
      ✗ calls delete.php, removes the deleted entries and updates summary
	Expected '57 KB' to equal '58 KB'.
	    at apps/files/tests/js/filelistSpec.js:612:47

    List rendering
      ✗ updates summary using the file sizes
	Expected '69 KB' to equal '70 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filelistSpec.js:1141:46)


  OCA.Files.FileSummary tests
    ✗ renders summary as text
	Expected '250 KB' to equal '256 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:47:47)

    ✗ increases summary when adding files
	Expected '500 KB' to equal '512 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:71:47)

    ✗ decreases summary when removing files
	Expected '125 KB' to equal '128 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:89:47)

    ✗ renders filtered summary as text
	Expected '250 KB' to equal '256 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:107:47)

    ✗ increases filtered summary when adding files
	Expected '500 KB' to equal '512 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:136:47)

    ✗ decreases filtered summary when removing files
	Expected '125 KB' to equal '128 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filesummarySpec.js:158:47)

[luzfcb]

@susnux @artonge Do you have any idea if the problem that this PR fixes could possibly also be the cause of nextcloud/android#11974 ?

[come-nc]

@susnux @artonge Do you have any idea if the problem that this PR fixes could possibly also be the cause of nextcloud/android#11974 ?

No, this PR only touches the web UI

[Jerome-Herbinet]

• Resolves: Group Folders size displays (for example) "104,9 MB" when "100 MB" is set (quota) groupfolders#2553