Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Show correct quota size (file size base 2) #40787

Merged
merged 2 commits into from Oct 6, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 5, 2023

Summary

While the whole web ui now again uses the correct file sizes, the files app is using the @nextcloud/files library directly.
For stable27 we are using a broken library version, so we need to adjust the calls to the file size function a bit.

Screenshots

before after
before after

Checklist

@susnux susnux added this to the Nextcloud 27.1.3 milestone Oct 5, 2023
@susnux susnux requested review from skjnldsv, a team, Fenn-CS and szaimen and removed request for a team October 5, 2023 14:23
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/stable27-wrong-quota-files-app branch from bf3262a to acdc319 Compare October 6, 2023 12:30
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux requested a review from artonge October 6, 2023 12:33
@skjnldsv skjnldsv merged commit c2d5a60 into stable27 Oct 6, 2023
39 checks passed
@skjnldsv skjnldsv deleted the fix/stable27-wrong-quota-files-app branch October 6, 2023 14:36
@blizzz blizzz mentioned this pull request Oct 9, 2023
@dinosmm
Copy link

dinosmm commented Oct 27, 2023

Is this fix merged in 27.1.3 stable?

@skjnldsv
Copy link
Member

image

@dinosmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants