Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cypress): only use the cypress cloud on pull requests #40736

Merged
merged 1 commit into from Oct 2, 2023
Merged

test(cypress): only use the cypress cloud on pull requests #40736

merged 1 commit into from Oct 2, 2023

Conversation

max-nextcloud
Copy link
Contributor

  • Disable recording on integration branches.
  • No parallelization on integration branches.

This will still run the cypress tests - but a bit slower and without recordings.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • tweaks the ci test setup - so no additional tests needed
  • not needed: Screenshots before/after for front-end changes
  • not needed: Documentation (manuals or wiki) has been updated or is not required
  • not needed: Backports requested where applicable (ex: critical bugfixes)

@max-nextcloud
test(cypress): only use the cypress cloud on pull requests
716d1a2 
* Disable recording on integration branches.
* No parallelization on integration branches.

This will still run the cypress tests - but a bit slower and without recordings.

The matrix syntax to enable this is somewhat hard to parse.
In case of a PR the matrix will contain one entry for use-cypress-cloud
with the value `true`. Otherwise it will have one entry `false`.

This way we can exclude containers for the case without the cypress cloud.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the test/cypress-record-in-prs-only branch from c3afb31 to 716d1a2 Compare October 2, 2023 09:14
@max-nextcloud max-nextcloud merged commit 5ddffcb into master Oct 2, 2023
43 checks passed
@max-nextcloud max-nextcloud deleted the test/cypress-record-in-prs-only branch October 2, 2023 10:56
@max-nextcloud max-nextcloud mentioned this pull request Oct 4, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@max-nextcloud @mejo- @artonge