fix(cypress): empty group, tag and ci-build-id when not using cypress cloud #40770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
fix/cypress-on-branches
branch
from
ab58f2b
to
5f9558d
Compare
artonge
reviewed
Oct 4, 2023
max-nextcloud
force-pushed
the
fix/cypress-on-branches
branch
from
5f9558d
to
4b90b83
Compare
artonge
approved these changes
Oct 4, 2023
mejo-
approved these changes
Oct 5, 2023
max-nextcloud
force-pushed
the
fix/cypress-on-branches
branch
from
4b90b83
to
c8d1ee7
Compare
Empty `group`, `tag` and `ci-build-id` when `record` is false. When not using cypress cloud these need to be empty. Note that cypress expects strings for group and tag. Therefore `false` will be interpreted as `"false"`. Use an empty string instead. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/cypress-on-branches
branch
from
c8d1ee7
to
a6d2b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress is currently failing in master and stable branches due to #40736
https://github.com/nextcloud/server/actions/runs/6408685873/job/17398449900
This fixes it by leaving the settings that only work with
recordempty.Tested here:
https://github.com/nextcloud/server/actions/runs/6409023706/job/17399426108