Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not lint external apps #40764

Merged
merged 1 commit into from Oct 5, 2023

Conversation

ChristophWurst
Copy link
Member

Summary

Running npm run lint on master scans all apps and therefore takes a long time and might format apps in unwanted ways. Moreover, if there is an incompatible eslint configin one of the apps, like Contacts, the linting errors out after ~30s.

$ npm run lint

> nextcloud@1.0.0 lint
> eslint apps core


Oops! Something went wrong! :(

ESLint: 8.46.0

Error: apps/contacts/.eslintrc.js » @nextcloud/eslint-config/typescript:
        Configuration for rule "n/no-unpublished-import" is invalid:
        Value {"allowModules":["@vue/test-utils","@testing-library/vue"],"ignoreTypeImport":false} should NOT have additional properties.

By using a short script we can build a list of apps that are part of the server repo. Lint now finishes in ~11s on my machine.

The same trick is also used for sass: #38590.

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Oct 4, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 4, 2023
@ChristophWurst ChristophWurst merged commit f3f2d9b into master Oct 5, 2023
38 of 39 checks passed
@ChristophWurst ChristophWurst deleted the chore/eslint-no-external-apps branch October 5, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants