Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaner code with null safe #41478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleaner code with null safe #41478

wants to merge 1 commit into from

Conversation

ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl ArtificialOwl requested review from a team, icewind1991, Altahrim and sorbaugh and removed request for a team November 15, 2023 00:37
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Nov 15, 2023
@ArtificialOwl ArtificialOwl added this to the Nextcloud 28 milestone Nov 15, 2023
@blizzz blizzz mentioned this pull request Nov 15, 2023
Merged
@ArtificialOwl
Copy link
Member Author

same issue about null safe: vimeo/psalm#10316

The code is good, the error is a false positive.

@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@icewind1991
Copy link
Member

if the false positive doesn't go away with the rebase you can suppress it with a comment

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/null-safe-metadata branch 2 times, most recently from a770e58 to a24bc14 Compare March 11, 2024 10:44
@ArtificialOwl
fix(core) null safe on metadata
681498a 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@Altahrim Altahrim Altahrim approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArtificialOwl @icewind1991 @Altahrim @blizzz