Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "global search" to "unified search" #42094

Merged
merged 2 commits into from Dec 12, 2023
Merged

Rename "global search" to "unified search" #42094

merged 2 commits into from Dec 12, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Dec 7, 2023

  • Changes appearances of "Global search" to "Unified search" in UI
  • Refactors code, to remove usage of term "GlobalSearch" in files and code structure
  • Rename old unified search to legacy-unified-search

@Fenn-CS Fenn-CS added 3. to review Waiting for reviews feature: search labels Dec 7, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Dec 7, 2023
@AndyScherzinger
Copy link
Member

/backport to stable28

@Fenn-CS Fenn-CS force-pushed the refactor-global-search-to-unified-search branch 2 times, most recently from 6a212f3 to b2464eb Compare December 7, 2023 12:29
@sorbaugh sorbaugh self-requested a review December 7, 2023 12:49
@Fenn-CS Fenn-CS force-pushed the refactor-global-search-to-unified-search branch from b2464eb to 84d1dbd Compare December 7, 2023 13:05
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 7, 2023

/compile

@Fenn-CS Fenn-CS mentioned this pull request Dec 7, 2023
Merged
@Fenn-CS Fenn-CS force-pushed the refactor-global-search-to-unified-search branch 6 times, most recently from c9119b5 to 259f671 Compare December 11, 2023 13:36
@Fenn-CS Fenn-CS force-pushed the refactor-global-search-to-unified-search branch from 259f671 to 11467f2 Compare December 11, 2023 15:13
@Fenn-CS Fenn-CS requested a review from susnux December 11, 2023 15:16
susnux
susnux requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and no search is loaded at all because of this error:

Uncaught Error: Could not find initial state limit-default of unified-search
    r index.es.mjs:13
    54201 UnifiedSearchService.js:30
    Webpack 5
        o
        c
        O
        <anonymous>
        <anonymous>
index.es.mjs:13:14

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 11, 2023

Tested and no search is loaded at all because of this error:

Uncaught Error: Could not find initial state limit-default of unified-search
r index.es.mjs:13
54201 UnifiedSearchService.js:30
Webpack 5
o
c
O


index.es.mjs:13:14

This change does not contain the build, did you watch or build? I can't see this?

@Fenn-CS Fenn-CS force-pushed the refactor-global-search-to-unified-search branch from 11467f2 to 1de5ad6 Compare December 11, 2023 15:33
emoral435
emoral435 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out in my dev setup and works, also looked over the code and it looks good to me 👍

@emoral435
Copy link
Contributor

Tested and no search is loaded at all because of this error:

I think it is because of not running npm build or watch, as @Fenn-CS mentioned. After running watch, the app works as expected on my dev setup with no error

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 12, 2023

@susnux Since, you left a change request on this, I would like you to take a look one more time, thank you!

@Fenn-CS Fenn-CS requested a review from susnux December 12, 2023 18:49
@Fenn-CS @susnux
Rename "global search" to "unified search"
0b171f6 
- Changes appearances of "Global search" to "Unified search" in UI
- Refactors code, to remove usage of term "GlobalSearch" in files and code
 structure
- Rename old unified search to `legacy-unified-search`

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@susnux susnux force-pushed the refactor-global-search-to-unified-search branch from 1de5ad6 to 0b171f6 Compare December 12, 2023 19:35
@susnux
chore: Compile assets
2f66897 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit c734a18 into master Dec 12, 2023
49 of 50 checks passed
@susnux susnux deleted the refactor-global-search-to-unified-search branch December 12, 2023 20:13
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 12, 2023

/backport to stable28

@Fenn-CS Fenn-CS mentioned this pull request Dec 12, 2023
Merged
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 13, 2023

/backport to stable28

@Pytal Pytal mentioned this pull request Dec 14, 2023
Merged
2 tasks
@Fenn-CS Fenn-CS mentioned this pull request Dec 21, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@emoral435 emoral435 emoral435 approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: search
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fenn-CS @AndyScherzinger @emoral435 @susnux @skjnldsv