Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified search improvements #42167

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Unified search improvements #42167

merged 4 commits into from
Dec 13, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Dec 11, 2023

Resolves : #41381, #41939

@nfebe
Copy link
Contributor Author

nfebe commented Dec 12, 2023

Users can now see themselves in the people filter as "Me" once, they start searching the filtering would exclude the authenticated user from the results.

Screenshot from 2023-12-12 19-45-15

@nfebe nfebe marked this pull request as ready for review December 12, 2023 18:52
@nfebe nfebe added 3. to review Waiting for reviews feature: search labels Dec 12, 2023
@nfebe nfebe linked an issue Dec 12, 2023 that may be closed by this pull request
@susnux
Copy link
Contributor

susnux commented Dec 12, 2023

@fenn-cs conflicts

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
On change/input from user which has the effect of filtering,
 we want to send the query to the API to obtained fresh results,
 based on the databased on not just preloaded contacts.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
As expected, a user does not see themselves in their contact list,
 however, when using the contact list for filtering search, a user,
 might want to limit the search to things that pertain to them.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the unified-search-improvements branch from 03fcf5f to c0374c7 Compare December 12, 2023 20:25
@nfebe
Copy link
Contributor Author

nfebe commented Dec 12, 2023

@susnux That was the result of compiling and merge : #42094, now fixed!

@nfebe
Copy link
Contributor Author

nfebe commented Dec 12, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28.0.1 milestone Dec 12, 2023
@susnux susnux modified the milestones: Nextcloud 28.0.1, Nextcloud 29 Dec 12, 2023
@nfebe nfebe merged commit 63babd2 into master Dec 13, 2023
42 checks passed
@nfebe nfebe deleted the unified-search-improvements branch December 13, 2023 08:53
@nfebe
Copy link
Contributor Author

nfebe commented Dec 13, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can not search for "own" search results Global search beta follow up
6 participants