feat(caldav): add repair steps in sabre calendarobject change hook #42347
Conversation
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
added
2. developing
tcitworld
requested review from
ChristophWurst and
miaulalala
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Compare descriptions | ||
| $isSameDescription = (string) $oldObject->DESCRIPTION === (string) $newObject->DESCRIPTION; | ||
| $isSameXAltDesc = (string) $oldObject->{self::X_ALT_DESC_PROP_NAME} === (string) $newObject->{self::X_ALT_DESC_PROP_NAME}; | ||
| $isSameAltRep = (string) $oldObject->DESCRIPTION['ALTREP'] === (string) $newObject->DESCRIPTION['ALTREP']; |
Check failure
Code scanning / Psalm
InvalidCast Error
| // Compare descriptions | ||
| $isSameDescription = (string) $oldObject->DESCRIPTION === (string) $newObject->DESCRIPTION; | ||
| $isSameXAltDesc = (string) $oldObject->{self::X_ALT_DESC_PROP_NAME} === (string) $newObject->{self::X_ALT_DESC_PROP_NAME}; | ||
| $isSameAltRep = (string) $oldObject->DESCRIPTION['ALTREP'] === (string) $newObject->DESCRIPTION['ALTREP']; |
Check failure
Code scanning / Psalm
InvalidCast Error
|
|
||
| public function onCalendarObjectChange(?VCalendar $oldVCalendar, ?VCalendar $newVCalendar, bool &$modified): void { | ||
| $keyedOldComponents = []; | ||
| foreach ($oldVCalendar->children() as $child) { |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| if (!($child instanceof Component)) { | ||
| continue; | ||
| } | ||
| $keyedOldComponents[$child->UID] = $child; |
Check notice
Code scanning / Psalm
PossiblyNullArrayOffset Note
|
|
||
| class Plugin extends ServerPlugin { | ||
|
|
||
| private Server $server; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
| } | ||
|
|
||
| public function registerRepairStep(string $repairStep): self { | ||
| $this->addRepairStep(new $repairStep); |
Check notice
Code scanning / Psalm
InvalidStringClass Note
| } | ||
|
|
||
| public function registerRepairStep(string $repairStep): self { | ||
| $this->addRepairStep(new $repairStep); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion Note
Summary
Introduce a middleware repair step for calendar data before it's being saved or updated.
TODO
Checklist