Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Aria-hide contacts menu icon images #42713

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 11, 2024

Summary

Add aria-hidden to the decorative image icons of the contacts menu.

I do not have the means to verify the accessibility of the icon after the change. Accessibility experts, please give this a test.

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much into the a11y details 🙈
But change looks good to me and aligned with issue discussion

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, thanks!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 11, 2024
@ChristophWurst ChristophWurst merged commit f6d850e into master Jan 11, 2024
41 checks passed
@ChristophWurst ChristophWurst deleted the fix/a11y/aria-hide-contacts-menu-images branch January 11, 2024 16:40
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@JuliaKirschenheuter
Copy link
Contributor

/backport 5198c1c to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst ChristophWurst restored the fix/a11y/aria-hide-contacts-menu-images branch January 12, 2024 13:17
@ChristophWurst ChristophWurst deleted the fix/a11y/aria-hide-contacts-menu-images branch January 12, 2024 13:18
@blizzz blizzz mentioned this pull request Mar 5, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug feature: contacts menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace entries of action menu for contacts inside of contacts menu
3 participants