Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppDirsWithDifferentOwnerTest #42790

Merged
merged 1 commit into from Jan 15, 2024
Merged

Fix AppDirsWithDifferentOwnerTest #42790

merged 1 commit into from Jan 15, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 15, 2024 •
edited

Follow up of #42176

Summary

Fix tests by avoiding:

There was 1 error:

1) OCA\Settings\Tests\AppDirsWithDifferentOwnerTest::testAppDirectoryOwnersOk
Creation of dynamic property OCA\Settings\Tests\AppDirsWithDifferentOwnerTest::$dirsToRemove is deprecated

/__w/server/server/apps/settings/tests/SetupChecks/AppDirsWithDifferentOwnerTest.php:64

Checklist

@come-nc
Fix AppDirsWithDifferentOwnerTest
d1aac16 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Jan 15, 2024
@come-nc come-nc requested review from a team, ArtificialOwl, blizzz and sorbaugh and removed request for a team January 15, 2024 09:34
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 15, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Jan 15, 2024
@come-nc come-nc mentioned this pull request Jan 15, 2024
Merged
4 tasks
@blizzz blizzz merged commit e5ef58b into master Jan 15, 2024
49 of 50 checks passed
@blizzz blizzz deleted the fix/fix-settings-appdirs-test branch January 15, 2024 16:43
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@come-nc come-nc mentioned this pull request Mar 18, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@come-nc @blizzz @artonge