Migrate remaining setup checks to new API

[come-nc]

Remaining checks not using the new API:

• isBruteforceThrottled (Your remote address was identified as "{remoteAddress}" and is bruteforce throttled at the moment slowing down the performance of various requests…) Migrate bruteforce throttle check #41435
• forwardedForHeadersWorking (The reverse proxy header configuration is incorrect, or you are accessing Nextcloud from a trusted proxy. If not, this is a security issue and can allow an attacker…) Migrate forwarded for headers check #41438
• OpcacheSetupRecommendations (The PHP OPcache module is not properly configured…) Migrate opcache check to new SetupCheck API #41547
• missingIndexes (The database is missing some indexes…) Migrate database missing checks #41460
• missingPrimaryKeys (The database is missing some primary keys…) Migrate database missing checks #41460
• missingColumns (The database is missing some optional columns…) Migrate database missing checks #41460
• isImagickEnabled (The PHP module "imagick" is not enabled although the theming app is) Migrate PHP imagick module check to new SetupCheck API #42177
• imageMagickLacksSVGSupport (Module php-imagick in this instance has no SVG support) Migrate PHP imagick module check to new SetupCheck API #42177
• pendingBigIntConversionColumns (Some columns in the database are missing a conversion to big int…) Migrate database pending bigint conversions #41468
• isSqliteUsed (SQLite is currently being used as the backend database…) -> Merge sqlite check to database check #41535
• isMemoryLimitSufficient Migrate memory_limit check to new SetupCheck API #41086
• appDirsWithDifferentOwner (Some app directories are owned by a different user than…) Migrate app dir owner check to new SetupCheck API #42176
• hasPassedCodeIntegrityCheck Migrate code integrity to SetupCheck API #41312
• suggestedOverwriteCliURL (Please make sure to set the "overwrite.cli.url" option in your config.php file to the URL that your users mainly use to access this Nextcloud…) Migrate overwrite.cli.url setup check to new API #42796
• cronErrors (It was not possible to execute the cron job via CLI. The following technical errors have appeared:…) Migrate cron setup checks to new API #42802
• isUsedTlsLibOutdated Remove obsolete check of curl SSL version #42807
• isCorrectMemcachedPHPModuleInstalled (Memcached is configured as distributed cache, but the wrong PHP module "memcache" is installed…) Migrate memcached PHP module setup check to new API #42812
• isSettimelimitAvailable (The PHP function "set_time_limit" is not available…) Migrate set_time_limit setup check to new API #42814
• areWebauthnExtensionsEnabled (The PHP modules "gmp" and/or "bcmath" are not enabled) Merge gmp and bcmath module checks with the existing PHP modules setupcheck #42829
• isMysqlUsedWithoutUTF8MB4 (MySQL is used as database but does not support 4-byte characters…) Migrate MySQL utf8mb4 check to new SetupCheck API #42836
• isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed Migrate available temp space check to new SetupCheck API #42839
• temporaryDirectoryWritable Migrate available temp space check to new SetupCheck API #42839
• isFairUseOfFreePushService Migrate fair use of free push service check to new SetupCheck API #42939

Checks done on frontend side:

• 'This instance is running in debug mode. Only enable this for local development and not in production environments.' Migrate debug mode check to new SetupCheck API #42942
• enh(setting): Migrate OCM / OCS provider tests to SetupCheck #43607
• Check whether the WOFF2 URLs works enh: Migrate WOFF2 loading check to SetupCheck #43588
• 'Your data directory and files are probably accessible from the internet. The .htaccess file is not working. It is strongly recommended that you configure your web server so that the data directory is no longer accessible, or move the data directory outside the web server document root.' (feat(settings): Migrate data directory protection check to SetupCheck #43908)
• 'You are accessing your instance over a secure connection, however your instance is generating insecure URLs. This most likely means that you are behind a reverse proxy and the overwrite config variables are not set correctly.' feat(settings): Migrate SSL access and URL generation check to SetupCheck API #43906
• 'Accessing site insecurely via HTTP. You are strongly advised to set up your server to require HTTPS feat(settings): Migrate SSL access and URL generation check to SetupCheck API #43906
• Check whether the .well-known URLs works ( feat(settings): Migrate .well-known tests to SetupCheck #43939 )
• Strict-Transport-Security header (Migrate header check to setupcheck API #44067)
• Other security headers (Migrate header check to setupcheck API #44067)
• Check whether the WebDAV connection works fix: Migrate WebDAV endpoint check to SetupCheck API #44202

[come-nc]

Backport to 28 TODO:

• [stable28] Migrate setup checks to new SetupCheck API #42795
  • Migrate database pending bigint conversions #41468
  • Merge sqlite check to database check #41535
  • Migrate opcache check to new SetupCheck API #41547
  • Migrate app dir owner check to new SetupCheck API #42176
  • Migrate PHP imagick module check to new SetupCheck API #42177
  • Fix AppDirsWithDifferentOwnerTest #42790
• [stable28] Migrate database missing checks #42013
  • Migrate database missing checks #41460
• [stable28] Setup check migrations to new API #42918
  • Migrate code integrity to SetupCheck API #41312
  • Migrate overwrite.cli.url setup check to new API #42796
  • Migrate cron setup checks to new API #42802
  • Remove obsolete check of curl SSL version #42807
• [stable28] Migrate setup checks to new API - round 3 #44268
  • Migrate memcached PHP module setup check to new API #42812
  • Migrate set_time_limit setup check to new API #42814
  • Merge gmp and bcmath module checks with the existing PHP modules setupcheck #42829
  • Migrate MySQL utf8mb4 check to new SetupCheck API #42836
  • Migrate available temp space check to new SetupCheck API #42839
  • Migrate fair use of free push service check to new SetupCheck API #42939
  • Migrate debug mode check to new SetupCheck API #42942
• enh(setting): Migrate OCM / OCS provider tests to SetupCheck #43607
• enh: Migrate WOFF2 loading check to SetupCheck #43588
• feat(settings): Migrate data directory protection check to SetupCheck #43908
• feat(settings): Migrate SSL access and URL generation check to SetupCheck API #43906
• feat(settings): Migrate .well-known tests to SetupCheck #43939
• Migrate header check to setupcheck API #44067
• fix: Migrate WebDAV endpoint check to SetupCheck API #44202

[susnux]

So now only the backports are missing?

[come-nc]

I never backported the last ones but it does not makes much sense now, that late into 28 lifecycle.
I’m closing this, everything is migrated in 29 and higher.