Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate overwrite.cli.url setup check to new API #42796

Merged
merged 2 commits into from Jan 16, 2024
Merged

Migrate overwrite.cli.url setup check to new API #42796

merged 2 commits into from Jan 16, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 15, 2024 •
edited

See #41364

Summary

Migrate overwrite.cli.url setup check to new API

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Jan 15, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Jan 15, 2024
@come-nc come-nc self-assigned this Jan 15, 2024
@come-nc come-nc mentioned this pull request Jan 15, 2024
Open
33 tasks
@come-nc come-nc force-pushed the enh/migrate-overwritecliurl-setupcheck branch from 755a791 to b0382f8 Compare January 15, 2024 13:07
@come-nc come-nc changed the base branch from master to feat/migrate-code-integrity-check January 15, 2024 13:08
@come-nc come-nc marked this pull request as draft January 15, 2024 13:08
@come-nc come-nc force-pushed the enh/migrate-overwritecliurl-setupcheck branch from b0382f8 to 94ee5b5 Compare January 15, 2024 13:10
Base automatically changed from feat/migrate-code-integrity-check to master January 16, 2024 08:04
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991, Fenn-CS and susnux and removed request for a team January 16, 2024 08:05
@come-nc come-nc marked this pull request as ready for review January 16, 2024 08:05
@come-nc
Migrate overwrite.cli.url setup check to new API
0483064 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/migrate-overwritecliurl-setupcheck branch from 94ee5b5 to 0483064 Compare January 16, 2024 08:05
@come-nc
Fix CheckSetupControllerTest following overwrite.cli.url migration
7017b3e 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit 58b31a9 into master Jan 16, 2024
50 checks passed
@come-nc come-nc deleted the enh/migrate-overwritecliurl-setupcheck branch January 16, 2024 09:47
@come-nc come-nc mentioned this pull request Jan 18, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@susnux susnux Awaiting requested review from susnux

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@come-nc @Altahrim @artonge