Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Fix resolved nextcloud/files dep version and user quota parsing #43368

Merged
merged 3 commits into from Feb 9, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 5, 2024

Summary

Because of the package resolution algorithm nextcloud/files is resolved to v3.0.0

├─┬ @nextcloud/dialogs@4.2.4
│ └── @nextcloud/files@3.0.0 deduped
└── @nextcloud/files@3.0.0

So the previously used parseWebdavPermissions() function is no longer available

With this fix the correct non-breaking version is resolved

├─┬ @nextcloud/dialogs@4.2.4
│ └── @nextcloud/files@3.1.0
└── @nextcloud/files@3.0.0-beta.8

To fix the potentially breaking resolution of nextcloud/files v3.1.0 for nextcloud/dialogs we need to pin it in dialogs as well nextcloud-libraries/nextcloud-dialogs#1226 and bump it

New dependency tree:

├─┬ @nextcloud/dialogs@4.2.5
│ └── @nextcloud/files@3.0.0-beta.21
└── @nextcloud/files@3.0.0-beta.8

Checklist

@Pytal Pytal added this to the Nextcloud 27.1.7 milestone Feb 5, 2024
@Pytal Pytal requested review from susnux and skjnldsv February 5, 2024 21:52
@Pytal Pytal self-assigned this Feb 5, 2024
@Pytal Pytal changed the title fix(trashbin): Fix resolved nextcloud/files dep version [stable27] fix(trashbin): Fix resolved nextcloud/files dep version Feb 5, 2024
@Pytal Pytal changed the title [stable27] fix(trashbin): Fix resolved nextcloud/files dep version [stable27] fix: Fix resolved nextcloud/files dep version Feb 6, 2024
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 8, 2024
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal enabled auto-merge February 9, 2024 00:05
@Pytal Pytal changed the title [stable27] fix: Fix resolved nextcloud/files dep version [stable27] fix: Fix resolved nextcloud/files dep version and user quota Feb 9, 2024
… locales

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal changed the title [stable27] fix: Fix resolved nextcloud/files dep version and user quota [stable27] fix: Fix resolved nextcloud/files dep version and user quota parsing Feb 9, 2024
@Pytal Pytal merged commit 59caee0 into stable27 Feb 9, 2024
39 checks passed
@Pytal Pytal deleted the fix/trashbin-parse-dav branch February 9, 2024 01:13
This was referenced Feb 9, 2024
@lohphat
Copy link

lohphat commented Feb 16, 2024

Still awaiting patch on ubuntu snap channel.

@marcelklehr
Copy link
Member

@lohphat this will be released as part of v27.1.7 on 2024-02-22

@tomikkk
Copy link

tomikkk commented Mar 6, 2024

Still not visible on snap:

# snap list |grep nextcloud
nextcloud  27.1.6snap1    40228  latest/stable  nextcloud**  -

# snap refresh nextcloud
snap "nextcloud" has no updates available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: trashbin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants