get child ids for folder in a separate query during move #43531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
Fenn-CS
and removed request for
a team
blizzz
approved these changes
Feb 12, 2024
lib/private/Files/Cache/Cache.php
Outdated
| } catch (\OC\DatabaseException $e) { | ||
| $this->connection->rollBack(); | ||
| throw $e; | ||
| } | ||
| } else { | ||
| $this->connection->beginTransaction(); |
There was a problem hiding this comment.
It does not have a catch and rollback in the current implementation, it might be worth to add it? (optionally)
icewind1991
force-pushed
the
cache-move-select-children
branch
from
0f493e7
to
0bbc355
Compare
8 tasks
This was referenced Mar 12, 2024
Merged
Merged
Merged
icewind1991
force-pushed
the
cache-move-select-children
branch
from
0bbc355
to
dddf6ca
Compare
ChristophWurst
approved these changes
Jun 12, 2024
|
Conflicts |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
|
conflicts |
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzz
force-pushed
the
cache-move-select-children
branch
from
dddf6ca
to
082c6c6
Compare
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help reduce lock contention and hopefully resolve some deadlock issues with concurrent moves.