Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Fix undefined share object during expirationDate update #43685

Merged
merged 2 commits into from Feb 22, 2024
Merged

[stable28] Fix undefined share object during expirationDate update #43685

merged 2 commits into from Feb 22, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 20, 2024 •
edited by Fenn-CS

Backport of #43661

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 28.0.3 milestone Feb 20, 2024
@Fenn-CS Fenn-CS marked this pull request as ready for review February 20, 2024 12:01
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Feb 20, 2024

/compile

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews backport-request labels Feb 20, 2024
@skjnldsv skjnldsv mentioned this pull request Feb 21, 2024
Merged
@Fenn-CS
Fix undefined share object during expirationDate update
7200241 
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Feb 21, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
823143f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit ff54149 into stable28 Feb 22, 2024
40 of 41 checks passed
@skjnldsv skjnldsv deleted the backport/43661/stable28 branch February 22, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@emoral435 emoral435 emoral435 approved these changes

Assignees

@Fenn-CS Fenn-CS

Labels
4. to release Ready to be released and/or waiting for tests to finish 28-feedback feature: sharing
Projects
None yet
Milestone
Nextcloud 28.0.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fenn-CS @Altahrim @emoral435 @skjnldsv @nextcloud-command