[stable28] fix(UpdateNotifications): Handle numeric user ids #44095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
bug
3. to review
|
/backport to stable27 |
|
/backport to stable26 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -118,7 +118,7 @@ | |||
| ->setSubject('connection_error', ['days' => $numDays]); | |||
|
|
|||
| foreach ($this->getUsersToNotify() as $uid) { | |||
| $notification->setUser($uid); | |||
| $notification->setUser((string) $uid); | |||
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
| @@ -186,7 +186,7 @@ | |||
| } | |||
|
|
|||
| foreach ($this->getUsersToNotify() as $uid) { | |||
| $notification->setUser($uid); | |||
| $notification->setUser((string) $uid); | |||
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
susnux
approved these changes
Mar 8, 2024
8 tasks
nickvergessen
approved these changes
Mar 8, 2024
nickvergessen
deleted the
fix/updatenotifications/numeric-ids-v28-and-lower
branch
5 tasks
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Manual backport of #44093 for <=v28. Same change just a different file since things got moved around in master.
Checklist