Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new mdi New file menu icons #44368

Merged
merged 6 commits into from Mar 21, 2024
Merged

feat: Add new mdi New file menu icons #44368

merged 6 commits into from Mar 21, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 20, 2024 •
edited

Summary

  • Replace text, document, drawing, presentation, spreadsheet mimetype svgs with new mdi ones
  • Add new --icon-filetype-text and --icon-add-folder-description icon classes
  • Add support for modern iconSvgInline to TemplateFileCreator
    • Deprecate iconClass
Before After
image image
Files (mime type icons usage)
image

Checklist

@Pytal Pytal added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Mar 20, 2024
@Pytal Pytal added this to the Nextcloud 29 milestone Mar 20, 2024
@Pytal Pytal self-assigned this Mar 20, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner March 20, 2024 20:03
@Pytal Pytal mentioned this pull request Mar 20, 2024
Closed
3 tasks
@Pytal
feat: Add iconSvgInline to TemplateFileCreator
66e77d4 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Add mdi mimetype svgs
4816542 
- article for text
- description for x-office-document
- file-table-box for x-office-spreadsheet
- file-presentation-box for x-office-presentation
- drawing-box for x-office-drawing

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: Use default grey for text as background-image url svgs do not su…
8862fba 
…pport CSS variables

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/new-file-menu-icon-svg branch from bd60936 to bdf45d6 Compare March 20, 2024 23:09
@Pytal
feat: Add new icon-filetype-text and icon-add-folder-description
4722cbe 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
a172a09 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/new-file-menu-icon-svg branch from bdf45d6 to a172a09 Compare March 20, 2024 23:28
@Pytal
chore: Update openapi spec
7993471 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal enabled auto-merge March 20, 2024 23:57
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
Merged
@juliushaertl juliushaertl mentioned this pull request Mar 21, 2024
Merged
4 tasks
@Pytal Pytal merged commit 45efd28 into master Mar 21, 2024
167 checks passed
@Pytal Pytal deleted the feat/new-file-menu-icon-svg branch March 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@susnux susnux Awaiting requested review from susnux

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: files 🍀 2024-Spring
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @AndyScherzinger @juliushaertl