[stable27] fix: Wait until file has been added to filelist before opening #45031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
changed the title
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
fix/template-race-27
branch
from
164fa97
to
ed747d6
Compare
Pytal
approved these changes
Apr 25, 2024
Strange as according to docs await should work on any thenable object 🤔 |
|
@Pytal Thanks, I was actually wrong with why this happened. It turned out the await was working but depending on the current folder and filename, the $file entry is empty if the file is added to the end of the list and therefore not rendered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new file from a template there is a race condition between the file opening and adding the entry to the file list (which is required by some apps like ONLYOFFICE to obtain further info).
This can be reproduced by setting browser throttling of network connections to be very slow with ONLYOFFICE.
In order to fix that we should wait for the success callback of addAndFetchFileInfo before we continue any further and try to open the file. Await is not working here due to the usage of
$.Deferred()