Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] perf(deleteAction): Queue delete requests #45328

Merged
merged 3 commits into from
May 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 15, 2024

Backport of #45237

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
When multiple files are deleted at once, all the requests bombard the server
simultaneously, causing performance issues.

This commit adds queuing that limits the concurrency of these requests to 5
at a time.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@artonge
Copy link
Contributor

artonge commented May 16, 2024

/compile amend /

@artonge artonge marked this pull request as ready for review May 16, 2024 15:34
@artonge artonge requested a review from skjnldsv as a code owner May 16, 2024 15:34
@artonge artonge enabled auto-merge May 16, 2024 16:14
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2024
@artonge artonge merged commit 7eb718c into stable29 May 16, 2024
105 checks passed
@artonge artonge deleted the backport/45237/stable29 branch May 16, 2024 17:52
@Fenn-CS Fenn-CS removed their assignment May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: dav performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants