Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_versions): renaming file version when its not a string #45958

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 18, 2024

@susnux susnux added bug 3. to review Waiting for reviews labels Jun 18, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jun 18, 2024
@susnux susnux changed the title Fix/renaming file version when number fix(files_versions): renaming file version when its not a string Jun 18, 2024
@artonge
Copy link
Contributor

artonge commented Jun 19, 2024

@sanskar-soni-9 I think one e2e test is legitimately failing. Can you take a look at it? :)

@sanskar-soni-9
Copy link
Contributor

sanskar-soni-9 commented Jun 19, 2024

@artonge Its failing when undefined, oops... 😅
240619_21h31m18s_screenshot

I fixed it now in original PR

240619_21h40m56s_screenshot

@sanskar-soni-9
Copy link
Contributor

@artonge original PR is merged and I updated the fix and rebased with current master in my branch so do I need to create new PR?

@artonge
Copy link
Contributor

artonge commented Jun 19, 2024

@artonge original PR is merged and I updated the fix and rebased with current master in my branch so do I need to create new PR?

Can you try to update this PR? Not sure whether you have the permission.

Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
@susnux susnux force-pushed the fix/renaming-file-version-when-number branch from 3409c21 to 2aecc52 Compare June 19, 2024 22:32
@susnux
Copy link
Contributor Author

susnux commented Jun 19, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 392ee62 into master Jun 20, 2024
110 checks passed
@artonge artonge deleted the fix/renaming-file-version-when-number branch June 20, 2024 07:14
@susnux
Copy link
Contributor Author

susnux commented Jun 20, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jun 25, 2024

/backport to stable28

Copy link

backportbot bot commented Jun 25, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45958/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2aecc523 efe4e047

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45958/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Naming File Version a number removes ability to edit version
5 participants