Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Naming File Version a number removes ability to edit version #45642

Closed
4 tasks done
grnd-alt opened this issue Jun 3, 2024 · 3 comments · Fixed by #45733 or #45958
Closed
4 tasks done

[Bug]: Naming File Version a number removes ability to edit version #45642

grnd-alt opened this issue Jun 3, 2024 · 3 comments · Fixed by #45733 or #45958

Comments

@grnd-alt
Copy link
Member

grnd-alt commented Jun 3, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

When naming the version of a file to a number: e.g. 1.0

  1. it gets renamed to 1 after refresh
  2. the version can't be renamed as the input field is not rendered

Console throws:
t.innerversionlabel.trim is not a function
and:
this.$refs.labelInput is not defined

Steps to reproduce

  1. create a file
  2. open sharing side menu
  3. go to versions
  4. click edit version name in three dots menu
  5. insert a float
  6. reload page
  7. try to edit version name

Expected behavior

version name should stay editable
probably 1.0 should not be renamed to 1

Nextcloud Server version

27, 28,29 master

@grnd-alt grnd-alt added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 3, 2024
@joshtrichards joshtrichards added feature: versions 27-feedback 29-feedback 1. to develop Accepted and waiting to be taken care of feature: files and removed 27-feedback 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 3, 2024
@joshtrichards
Copy link
Member

Reproduced in 29.0.1. Thanks for the report!

@sanskar-soni-9
Copy link
Contributor

sanskar-soni-9 commented Jun 8, 2024

Hi @joshtrichards, looking for my first contribution

I found that server is saving and responding with correct version
240608_17h02m59s_screenshot

but it gets converted to int type in received response object

const response = await client.getDirectoryContents(path, {

240608_17h04m17s_screenshot

I fixed the renaming thing by formatting it to string in formatVersion function
should I raise PR for that?

@joshtrichards
Copy link
Member

joshtrichards commented Jun 8, 2024

should I raise PR for that?

Yes, please do so. And thanks for digging into this. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants