Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): app menu notification should be in the top right #46930

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(core): app menu notification should be in the top right #46930

merged 1 commit into from
Aug 1, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 31, 2024 •
edited
Loading

Fix #46929

Before After
image image

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 31, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 31, 2024
@skjnldsv skjnldsv requested review from jancborchardt, susnux and a team July 31, 2024 16:24
@skjnldsv skjnldsv self-assigned this Jul 31, 2024
@skjnldsv skjnldsv requested review from Fenn-CS and szaimen and removed request for a team July 31, 2024 16:24
susnux
susnux approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but personally I would not go back to physical properties but try to always stick with logical.

core/src/components/AppMenuIcon.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 31, 2024
@skjnldsv skjnldsv force-pushed the fix/app-menu-not-dot-pos branch 2 times, most recently from 80dbf4d to 21b2c3d Compare August 1, 2024 05:42
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 1, 2024
@skjnldsv skjnldsv requested a review from Pytal August 1, 2024 05:44
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2024
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 1, 2024

/compile rebase-amend /dist

@skjnldsv @nextcloud-command
fix(core): app menu notification should be in the top right
3ca6eb5 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 29661b0 into master Aug 1, 2024
103 of 110 checks passed
@skjnldsv skjnldsv deleted the fix/app-menu-not-dot-pos branch August 1, 2024 09:03
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Top Navigation notification bubble should be in the top right, as it is e.g. on iOS, Android...
3 participants
@skjnldsv @AndyScherzinger @susnux