Fix invalid theming URLs #4707
Merged
Fix invalid theming URLs #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
LukasReschke,
juliushaertl and
skjnldsv
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @LukasReschke and @schiessle to be potential reviewers. |
* logo and background image had the cache buster applied twice: background-image: url(http://192.168.99.100/server/core/img/logo.svg?v=0?v=0); Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-invalid-theming-urls
branch
from
7c31b84
to
ac04fb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4707 +/- ##
============================================
+ Coverage 54.27% 54.28% +<.01%
Complexity 22099 22099
============================================
Files 1361 1361
Lines 84708 84709 +1
Branches 1322 1322
============================================
+ Hits 45978 45984 +6
+ Misses 38730 38725 -5
|
LukasReschke
approved these changes
May 5, 2017
rullzer
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background-image: url(http://192.168.99.100/server/core/img/logo.svg?v=0?v=0);