-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve layout of buttons for two factor auth #4865
Conversation
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @icewind1991 and @ChristophWurst to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except my detail comment and what @ChristophWurst said! :)
core/css/guest.css
Outdated
color: rgba(255, 255, 255, 0.75); | ||
} | ||
.two-factor-link a.button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t need to be that specific, can be simply .two-factor-link .button
(without the a)
e262feb
to
6eff66c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4865 +/- ##
============================================
- Coverage 54.19% 54.18% -0.01%
+ Complexity 22168 22155 -13
============================================
Files 1364 1363 -1
Lines 84853 84842 -11
Branches 1322 1322
============================================
- Hits 45984 45970 -14
- Misses 38869 38872 +3
|
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
6eff66c
to
30443ac
Compare
Fixed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works! Looks a lot better now, thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈
Before:
After: